-
Notifications
You must be signed in to change notification settings - Fork 0
Roman to Integer #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Roman to Integer #42
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| //lint:file-ignore U1000 Ignore all unused code | ||
| package romantointeger | ||
|
|
||
| /* | ||
| レビュワーの方へ: | ||
| - このコードは既にGoの標準のフォーマッタで整形済みです。演算子の周りにスペースがあったりなかったりしますが、これはGoのフォーマッタによるもので、優先順位の高い演算子の周りにはスペースが入らず、低い演算子の周りには入るようになっています。https://qiita.com/tchssk/items/77030b4271cd192d0347 | ||
| */ | ||
|
|
||
| /* | ||
| 時間:25分 | ||
| 方針自体はすぐに思いついたが、単純に実装に時間がかかってしまった。 | ||
| */ | ||
| func romanToIntStep1(s string) int { | ||
| symbolToInt := map[rune]int{ | ||
| 'I': 1, | ||
| 'V': 5, | ||
| 'X': 10, | ||
| 'L': 50, | ||
| 'C': 100, | ||
| 'D': 500, | ||
| 'M': 1000, | ||
| } | ||
| total := 0 | ||
| runeS := []rune(s) | ||
| currIndex, nextIndex := 0, 1 | ||
| for currIndex < len(runeS) && nextIndex < len(runeS) { | ||
| curr, next := runeS[currIndex], runeS[nextIndex] | ||
| if (curr == 'I' && (next == 'V' || next == 'X')) || | ||
| (curr == 'X' && (next == 'L' || next == 'C')) || | ||
| (curr == 'C' && (next == 'D' || next == 'M')) { | ||
| total += symbolToInt[next] - symbolToInt[curr] | ||
| currIndex, nextIndex = currIndex+2, nextIndex+2 | ||
| continue | ||
| } | ||
| total += symbolToInt[curr] | ||
| currIndex, nextIndex = currIndex+1, nextIndex+1 | ||
| } | ||
| if currIndex < len(runeS) { | ||
| total += symbolToInt[runeS[currIndex]] | ||
| } | ||
| return total | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| //lint:file-ignore U1000 Ignore all unused code | ||
| package romantointeger | ||
|
|
||
| /* | ||
| レビュワーの方へ: | ||
| - このコードは既にGoの標準のフォーマッタで整形済みです。演算子の周りにスペースがあったりなかったりしますが、これはGoのフォーマッタによるもので、優先順位の高い演算子の周りにはスペースが入らず、低い演算子の周りには入るようになっています。https://qiita.com/tchssk/items/77030b4271cd192d0347 | ||
| */ | ||
|
|
||
| /* | ||
| 前のシンボルの方が後ろのシンボルよりも小さい場合として考えることができる。 | ||
| ただ個人的にはStep1の方が要件に明確に沿っているので良いのではと思っている。 | ||
rihib marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| */ | ||
| func romanToIntStep2(s string) int { | ||
| symbolToInt := map[rune]int{ | ||
| 'I': 1, | ||
| 'V': 5, | ||
| 'X': 10, | ||
| 'L': 50, | ||
| 'C': 100, | ||
| 'D': 500, | ||
| 'M': 1000, | ||
| } | ||
| total := 0 | ||
| runeS := []rune(s) | ||
| for i, r := range runeS { | ||
| if i+1 < len(runeS) && symbolToInt[r] < symbolToInt[runeS[i+1]] { | ||
rihib marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| total -= symbolToInt[r] | ||
| } else { | ||
| total += symbolToInt[r] | ||
| } | ||
| } | ||
| return total | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.