Skip to content

Hotfix/n+1 query resolve (Lazy Loading) #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Hotfix/n+1 query resolve (Lazy Loading) #73

wants to merge 3 commits into from

Conversation

@ShojibFlamon
Copy link

@ShojibFlamon ShojibFlamon commented Oct 25, 2025

Description

Fix lazy loading (n+1) issue in terms of enabling Model::shouldBeStrict

Fixes #72

Changes

  • Eager loaded role model while generating the Approval Flow Steps

Additional Notes

Please review the PR & merge it in your preferable time.

Thanks in advance @ringunger

@ShojibFlamon ShojibFlamon mentioned this pull request Oct 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug Report: Attempted to lazy load [role] on model [RingleSoft\LaravelProcessApproval\Models\ProcessApprovalFlowStep] but lazy loading is disabled.

1 participant

@ShojibFlamon