fix: docker compose build

[abcxff]

Fixes the docker compose build (got broken by project files reorg)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments

Project	Deployment	Preview	Comments	Updated (UTC)
rivet-cloud	Ignored			Oct 28, 2025 4:38am
rivet-inspector	Ignored	Preview		Oct 28, 2025 4:38am
rivet-site	Ignored	Preview		Oct 28, 2025 4:38am

[abcxff]

• feat(grafana): fix api dashboards #3193
• fix: docker compose build #3273 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[pkg-pr-new]

More templates

• example-ai-agent
• example-background-jobs
• example-better-auth-external-db
• example-bots
• chat-room
• example-cloudflare-workers
• example-cloudflare-workers-hono
• example-counter
• example-counter-serverless
• example-crdt
• example-cursors
• example-cursors-raw-websocket
• example-database
• example-deno
• example-sqlite
• example-elysia
• example-express
• example-freestyle
• example-game
• example-hono
• example-hono-bun
• example-hono-react
• example-kitchen-sink
• example-next-js
• example-rate
• example-raw-fetch-handler
• example-raw-websocket-handler
• example-raw-websocket-handler-proxy
• example-react
• example-smoke-test
• starter
• example-stream
• example-sync
• example-tenant
• example-trpc
• example-workflows

@rivetkit/actor

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/actor@3273

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@3273

@rivetkit/core

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/core@3273

@rivetkit/db

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/db@3273

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@3273

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@3273

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@3273

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@3273

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@3273

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@3273

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@3273

commit: e0b1ae3

[claude]

PR Review: Fix Docker Compose Build

Overview

This PR fixes Docker build context and Dockerfile paths across multiple Docker Compose configurations by adjusting the context from ../.. to ../../.. and updating Dockerfile paths to include the engine/ prefix.

Critical Issue ⚠️

The changes violate repository conventions outlined in CLAUDE.md:

According to the Configuration Management section in CLAUDE.md:

Do not make changes to docker/dev* configs. Instead, edit the template in docker/template/ and rerun (cd docker/template && pnpm start). This will regenerate the docker compose config for you.

This PR directly modifies generated files instead of updating the source template.

Required Changes

The changes need to be applied to the template source at engine/docker/template/src/docker-compose.ts and then regenerated. Looking at the diff, I can see the template was updated correctly at lines 174-175, 267-268, and 327-328:

context: "../../..",
dockerfile: "engine/docker/universal/Dockerfile",

And at engine/sdks/typescript/test-runner/Dockerfile:

context: "../../..",
dockerfile: "engine/sdks/typescript/test-runner/Dockerfile",

Action Required:

1. Revert all changes to the generated docker-compose.yml files
2. Keep only the changes to:
   • engine/docker/template/src/docker-compose.ts
   • engine/sdks/typescript/test-runner/Dockerfile
3. Run cd engine/docker/template && pnpm start to regenerate all docker-compose.yml files
4. Commit the regenerated files

Technical Review

Correctness of the Fix ✅

The path changes themselves are correct:

• Context change from ../.. to ../../.. accounts for the monorepo structure
• Dockerfile paths now correctly include the engine/ prefix
• The test-runner Dockerfile COPY commands are properly updated to match the new context

Files Modified:

• ✅ engine/docker/template/src/docker-compose.ts - Template source (correct)
• ✅ engine/sdks/typescript/test-runner/Dockerfile - Dockerfile source (correct)
• ❌ 6 generated docker-compose.yml files - Should be regenerated, not manually edited

Security & Performance

• ✅ No security concerns
• ✅ No performance impact
• ✅ Changes maintain proper Docker build context isolation

Testing Recommendations

After regenerating the files:

1. Test that Docker builds work: docker-compose build
2. Verify all services start correctly: docker-compose up -d
3. Check that file paths resolve correctly in running containers

Summary

The fix addresses a real issue with incorrect build contexts, but the implementation doesn't follow repository conventions. Please regenerate the docker-compose.yml files from the template rather than editing them directly.

---

Review generated by Claude Code

[claude]

Pull Request Review

Summary

This PR fixes Docker Compose build paths after a project reorganization that moved files into the engine/ subdirectory. The changes correctly update all Docker build contexts and Dockerfile paths across multiple compose configurations.

Code Quality: ✅ Excellent

Strengths:

• Systematic approach: All docker-compose files were updated consistently
• Source template updated: The fix was applied to engine/docker/template/src/docker-compose.ts, which is the correct approach per CLAUDE.md guidelines (line 173: "Do not make changes to docker/dev* configs. Instead, edit the template...")
• Generated files in sync: All generated docker-compose.yml files match the template changes
• Path corrections are accurate:
  • Build contexts changed from ../.. to ../../.. (correct - goes up 3 levels from engine/docker/*/ to repo root)
  • Dockerfile paths prefixed with engine/ (e.g., engine/docker/universal/Dockerfile, engine/sdks/typescript/test-runner/Dockerfile)

Files Updated:

• ✅ Template source: engine/docker/template/src/docker-compose.ts
• ✅ Generated configs: All 5 dev environment variants + prod-file-system
• ✅ Test runner Dockerfile: engine/sdks/typescript/test-runner/Dockerfile

Architecture Compliance: ✅

The changes align perfectly with the monorepo structure after the reorganization:

• Respects the new engine/ subdirectory structure
• Maintains proper relative paths from docker-compose locations
• Correctly references Dockerfiles at their new locations

Testing Recommendations:

1. Build verification - Test each docker-compose configuration builds successfully:

   cd engine/docker/dev && docker-compose build
   cd engine/docker/dev-multinode && docker-compose build
   # etc.

2. Runtime verification - Ensure containers start and services connect:

   cd engine/docker/dev && docker-compose up -d
   docker-compose ps
   docker-compose logs rivet-engine

3. Test runner verification - Confirm the test-runner Dockerfile builds:

   docker build -f engine/sdks/typescript/test-runner/Dockerfile .

Potential Issues: ⚠️ Minor

Note about CLAUDE.md:
The CLAUDE.md documentation (line 51) still references the old path:

cd docker/dev
docker-compose up -d

This should probably be updated to:

cd engine/docker/dev
docker-compose up -d

However, this is outside the scope of this PR and can be addressed separately.

Security: ✅ No Concerns

No security implications - pure path refactoring.

Performance: ✅ No Impact

Build context size remains the same (still building from repo root).

Final Verdict: ✅ APPROVE

This is a clean, necessary fix that properly addresses the docker-compose build breakage. The author correctly:

1. Updated the template source (not just generated files)
2. Applied changes consistently across all configurations
3. Used accurate relative paths

Recommendation: Approve and merge after verifying at least one docker-compose configuration builds successfully.

🤖 Generated with Claude Code

[claude]

PR Review: Docker Compose Build Fix

Summary

This PR fixes Docker build context paths that were broken after project files were reorganized. The changes correctly adjust Docker build contexts from the repository root to account for the new directory structure.

Code Quality ✅

Strengths:

• Consistent changes: All modifications follow the same pattern across all docker-compose files
• Correct approach: The PR updates both the generated docker-compose.yml files AND the source template (engine/docker/template/src/docker-compose.ts), which is the correct approach per CLAUDE.md guidelines
• Complete coverage: All affected files have been updated (5 docker-compose variants + template + test-runner Dockerfile)

Path changes are correct:

• Build context: ../.. → ../../.. (goes up one more level to reach repo root)
• Dockerfile path: docker/universal/Dockerfile → engine/docker/universal/Dockerfile
• Test runner path: sdks/typescript/test-runner/Dockerfile → engine/sdks/typescript/test-runner/Dockerfile

These changes align with the monorepo structure where the engine/ directory was introduced during reorganization.

Verification ✅

I verified that:

1. The Dockerfiles exist at the new paths (engine/docker/universal/Dockerfile and engine/sdks/typescript/test-runner/Dockerfile)
2. The Dockerfile COPY commands expect files at paths like engine/sdks/typescript/..., which confirms the context should be the repo root (../../.. from docker compose files)
3. The template source was updated, ensuring future regenerations will be correct

Potential Issues ⚠️

Note from CLAUDE.md:
The project instructions state: "Do not make changes to docker/dev* configs. Instead, edit the template in docker/template/ and rerun (cd docker/template && pnpm start)."

However, in this case:

• The template WAS updated (engine/docker/template/src/docker-compose.ts)
• The PR shows equal additions/deletions (99/99), suggesting the generated files were updated to match
• This appears to be a valid exception since the template AND generated files needed fixing

Recommendation: After merging, verify that running cd engine/docker/template && pnpm start produces no additional changes (i.e., the generated files match the template).

Testing Recommendations

Consider verifying:

1. Docker compose builds work in each environment variant:

   cd engine/docker/dev && docker-compose build rivet-engine
   cd engine/docker/dev-multinode && docker-compose build rivet-engine-0
   # etc.

2. The test-runner builds correctly:

   cd engine/docker/dev && docker-compose build runner

Security & Performance

• ✅ No security concerns
• ✅ No performance impact (build-time only changes)
• ✅ No changes to runtime behavior

Conclusion

Verdict: LGTM ✅

This is a straightforward, necessary fix that correctly addresses the docker build issues after the project reorganization. The changes are minimal, consistent, and complete. The fact that both the template and generated files were updated is appropriate for this type of structural fix.

Suggested merge strategy: Fast-forward merge after CI passes.