Skip to content

Conversation

@NathanFlurry
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented Oct 28, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
rivet-cloud Ignored Ignored Oct 28, 2025 1:00am
rivet-inspector Ignored Ignored Preview Oct 28, 2025 1:00am
rivet-site Ignored Ignored Preview Oct 28, 2025 1:00am

Copy link
Member Author

NathanFlurry commented Oct 28, 2025


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 28, 2025

More templates

@rivetkit/actor

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/actor@3277

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@3277

@rivetkit/core

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/core@3277

@rivetkit/db

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/db@3277

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@3277

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@3277

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@3277

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@3277

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@3277

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@3277

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@3277

commit: 41d1f0c

@claude
Copy link

claude bot commented Oct 28, 2025

Code Review

Thank you for adding this utility script! Overall, the code is clean and functional. Here are some observations and suggestions:

Positive Aspects

Consistent Pattern: The script follows the same structure as other scripts in scripts/api/
Good User Experience: Printing the equivalent curl command is helpful for debugging and learning
Proper Shebang: Uses #!/usr/bin/env tsx correctly for executable TypeScript scripts
Error Handling: Has proper validation and error messages for required inputs

Issues & Suggestions

1. Inconsistent Input Order

The script asks for inputs in this order: Endpoint → Token → Actor ID

However, other scripts in scripts/api/ follow this pattern: Token → Endpoint → Other params

Suggestion: Reorder to match the existing pattern for consistency (Token first, then Endpoint, then Actor ID)

2. Inconsistent Default Endpoint

This script defaults to api.rivet.dev (production), while runner-configs/list.ts and runners/list.ts default to http://localhost:6420 (local development).

Question: Is api.rivet.dev the intended default? If this is for production testing, that is fine. Otherwise, consider aligning with local development defaults.

3. Token Security in Curl Command

The script prints the token in the curl command (scripts/api/gateway/ping-actor.ts:38).

Security Consideration: While this is a developer utility script, printing tokens to console could expose them in:

  • Shared terminal sessions
  • Terminal history files
  • Screenshots/logs

Suggestion: Consider masking the token in the printed curl command or adding a warning message.

4. Response Handling

The script uses response.text() which is appropriate since we do not know what the actor will return. However, other scripts use response.json() and format output.

Suggestion: Consider handling both JSON and text responses by checking the content-type header.

Summary

The script is well-written and functional. The main suggestions are:

  1. Reorder input prompts for consistency
  2. Verify the default endpoint is intentional
  3. Consider token security in debug output
  4. Optionally improve response format handling

These are mostly minor consistency and security considerations rather than bugs. Great work!


Review generated with assistance from Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants