Skip to content

Conversation

@NathanFlurry
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented Oct 28, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
rivet-site Ready Ready Preview Comment Oct 28, 2025 2:58am
2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
rivet-cloud Ignored Ignored Oct 28, 2025 2:58am
rivet-inspector Ignored Ignored Preview Oct 28, 2025 2:58am

Copy link
Member Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude
Copy link

claude bot commented Oct 28, 2025

Pull Request Review

Summary

This PR refactors the website marketing homepage and documentation structure by flattening the actors docs structure and enhancing the homepage with new sections showcasing use cases and deployment options.

Code Quality & Best Practices

Strengths

  • Good component separation with dedicated UseCases and DeploymentOptionsSection components
  • Proper TypeScript typing with interfaces
  • Good responsive design with Tailwind classes
  • Proper semantic HTML and accessibility

Issues Found

1. Typo in self-hosting/index.mdx line 6
applciations should be applications

2. Broken link in DeploymentOptionsSection.tsx line 69
/docs/general/self-hosting should be /docs/self-hosting based on sitemap

3. Grammar in HeroSection.tsx line 26
in to should be into (one word)

4. Commented code in HeroSection.tsx
Multiple blocks of commented hero copy (lines 30-86) should be removed

Potential Bugs

1. UseCases.tsx lines 135-142
Non-null assertions assume use cases exist. If missing, will throw runtime error. Add null checks.

2. UseCases.tsx handleMouseMove
Runs on every mousemove without throttling. Could cause performance issues with multiple cards.

Test Coverage

No tests included for new components. Consider adding unit tests and link validation tests.

Recommendations

High Priority:

  1. Fix typo: applciations to applications
  2. Fix broken link: /docs/general/self-hosting to /docs/self-hosting
  3. Fix grammar: in to to into
  4. Add null checks for use case lookups

Medium Priority:

  1. Remove commented-out code
  2. Add performance optimization for mouse tracking
  3. Add tests

Overall Assessment

Solid refactoring with good code quality. Main issues are minor but should be fixed before merging.

Recommendation: Request changes for typo, broken link, and grammar fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants