feat(agent-os): add acpTimeoutMs passthrough test fixture and tests#4552
feat(agent-os): add acpTimeoutMs passthrough test fixture and tests#4552brittianwarner wants to merge 2 commits intomainfrom
Conversation
Add test fixture and driver tests verifying that the acpTimeoutMs option passes through the actor config to AgentOs.create() without errors. The actor layer already forwards AgentOsOptions transparently via spread, so no code changes are needed. These tests confirm the option is accepted and basic operations work with it set. Blocked: bump @rivet-dev/agent-os-core once the version with acpTimeoutMs in AgentOsOptions and CreateSessionOptions is published, then remove the type assertion in the fixture.
|
This PR was not deployed automatically as @brittianwarner does not have access to the Railway project. In order to get automatic PR deploys, please add @brittianwarner to your workspace on Railway. |
PR Review: feat(agent-os): add acpTimeoutMs passthrough test fixture and testsOverall this is a clean, well-scoped PR with a clear purpose. A few things to look at. Concerns Type assertion silences broader type errors The
The new test calls Tests verify actor works, not timeout is forwarded The two new tests confirm the VM boots and exec runs, but do not assert that Minor
Positives
|
- Reference PR #4552 in TODO comment for tracking - Rename test descriptions to be more precise about what is asserted
1 participant
Summary
agentOsTimeoutTestActor) configured withacpTimeoutMs: 300_000in options to verify the option passes through the actor layer toAgentOs.create()without errors.AgentOsOptionstransparently via spread inbuildVmOptions()andCreateSessionOptionsdirectly increateSession().Blocked on
Bump
@rivet-dev/agent-os-coreonce the version withacpTimeoutMsinAgentOsOptionsandCreateSessionOptionsis published, then remove theas AgentOsOptionstype assertion in the fixture.Context
The upstream
@rivet-dev/agent-os-coreis getting an activity-aware ACP timeout feature:acpTimeoutMsfield on bothAgentOsOptions(VM-level default) andCreateSessionOptions(per-session override)The actor layer in this repo already passes both option types through transparently, so no structural code changes are needed here. These tests confirm the option is accepted and operations work with it set.