Open
Conversation
Properties that match do not contribute to understanding the test failure.
Owner
|
Hi Alex, thank you for the pull request and sorry for the delay. Looks great, but I think your Do you think you can update the PR accordingly? Although I doubt that anyone already uses the diff API for custom matchers, I will nonetheless increase the major version when merging due to the breaking API changes. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
hasPropertieswe are more interested in the given properties than in anything else. So the diff becomes more useful if only the differing aspects are shown.describeMismatchuses a similar reasoning.In order to do this, I had to change the diff API. Cp. #7 (comment)
I refactored the early beginnings that we had so far.
When creating the diff objects in
hasProperties, I considered the following situations:__.hasProperties({a: __.hasProperties({b: __.greaterThan(2)})})Real-life example
Before
After
(with a custom property matcher for nicer formatting)