Conversation
When an OS Layer is added, creates a hidden div containing terms and conditions. Adds an event handler to the terms and conditions link to show the div when the link is clicked.
If options are needed but no apiUrl then allows null to be passed to indicate this.
options were being ignored and were unable to override default layer settings such as maxZoom. Note: it would also be possible to merge wmsParams in to options so that they too can be overridden by user options. However, in this case, Leaflet would change width and height settings for retina screens and I'm unable to test if this would work so I left it alone.
Allows a layer option of {termsURL: 'http://some/preferred/url') for the
link to terms and conditions if the popup version is unsuitable.
|
Nice approach! Works well and does the job but... I'm not sure it is worth burdening the library with this content, like you say, and then having to maintain the content. I feel the logo is less likely to change and I'd prefer a few extra bytes to save a network request to a URL that may change - ideally OS would provide a link or at least an anchor for the End User T&Cs and we could use that. I'm going to put it on hold for this version if thats OK? I don't think it would be a problem to add this in version 1.0.1 for example, I will think about it some more and get version 1.0 out first. I see the End User T&Cs are way down the content the other end of the link we have but I think for now that satisfies the point 4.6.1 in the developer agreement. |
|
Agreed. I have raised the issue on the forum, https://www.ordnancesurvey.co.uk/forums/discussion/1010372/link-to-end-user-terms but am deeply pessimistic that any action will be taken. |
2 participants
This pull request offers the following:
It's a heck of a lot of code to add for a simple thing. The advantage is that, by default, users of the code will conform with OS Terms and Conditions. Whether it is worth burdening the module with that responsibility is a good question!