Change: Upgrade Typhoeus version #3
Open
+3
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change: Version 0.5.x of Typhoeus does not support cache. Version >0.6.2 does.
Owner
|
Thanks! Yeah, the massive changes in Typhoeus have been bumming me out. I haven't looked into 0.6.x yet myself, and I know 0.5 didn't work well with my applications. I might merge this to a new "typhoeus-0.5" branch for now so anyone who needs it can find it easily. |
Contributor
Author
That sounds like the right approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change: Version 0.5.x of Typhoeus does not support cache. Version >0.6.2 does.
https://github.com/typhoeus/typhoeus/blob/master/CHANGELOG.md
I had some need for a newer version of Typhoeus. So here are a couple changes that will allow cloud_assets to play nice with Typhoeus 0.5.x
The bad thing about this version of Typhoeus is that they removed caching. But then it's brought back again in version 0.6.2. So if caching is important, than maybe consider ignoring this PR or else investigate compatibility w/ cloud_assets and 0.6.x. The only reason I didn't is because I have other gems that don't work with Typhoeus 0.6, and I didn't want to spend any more time investigating.