refactor: add forRoot method to L10nIntlModule#355
Open
pweyrich wants to merge 2 commits intorobisim74:masterfrom
Open
refactor: add forRoot method to L10nIntlModule#355pweyrich wants to merge 2 commits intorobisim74:masterfrom
pweyrich wants to merge 2 commits intorobisim74:masterfrom
Conversation
BREAKING CHANGE: L10nIntlModule doesn't ship with a provider for L10nIntlService anymore. Use L10nIntlModule.forRoot() instead to include a provider for L10nIntlService.
Owner
|
Sorry, I haven't had a chance to try this pr. But I don't see the benefit of having a forRoot here. |
Contributor
Author
|
Hey @robisim74 This aims to:
Best regards |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
L10nIntlModule doesn't ship with a provider for L10nIntlService anymore. Use L10nIntlModule.forRoot() or provideL10nIntl() instead to include a provider for L10nIntlService.