Added Confidence Argument to keypoint detection model#354
Added Confidence Argument to keypoint detection model#354SolomonLake merged 24 commits intoroboflow:mainfrom
Conversation
|
|
SolomonLake
left a comment
There was a problem hiding this comment.
can you make sure you are running the tests locally using python3 -m unittest (or python) from the root of repo?
You can see test failures here: https://github.com/roboflow/roboflow-python/actions/runs/16078304796/job/45497459911?pr=354
I left suggested fixes which are all going to be necessary.
Co-authored-by: Solomon Lake Giffen-Hunter <lakegh@gmail.com>
Co-authored-by: Solomon Lake Giffen-Hunter <lakegh@gmail.com>
Co-authored-by: Solomon Lake Giffen-Hunter <lakegh@gmail.com>
Co-authored-by: Solomon Lake Giffen-Hunter <lakegh@gmail.com>
|
@SolomonLake The Local path issues have been updated according to your suggestions as well as the switch to "with self.assertRaises(Exception):" and the env api-key variable. |
|
All tests are now successful. The issue was with some referenced file paths |
SolomonLake
left a comment
There was a problem hiding this comment.
Looks good to me, and tested it locally. Thanks for the contribution!
Description
A new "Confidence" argument has been added to the keypoint detection model (based on the confidence argument found in the object detection model)
Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
A Dedicated keypoint detection model test file has been made with multiple test cases including one where the confidence is changed
Any specific deployment considerations
Docs