Skip to content

fix is_prediction function call #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iurisilvio merged 1 commit into from
Sep 10, 2025
Merged

fix is_prediction function call #413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion roboflow/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
from roboflow.models import CLIPModel, GazeModel # noqa: F401
from roboflow.util.general import write_line

__version__ = "1.2.8"
__version__ = "1.2.9"


def check_key(api_key, model, notebook, num_retries=0):
Expand Down
2 changes: 1 addition & 1 deletion roboflow/core/workspace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,6 @@ def _upload_image(imagedesc):
sequence_number=imagedesc.get("index"),
sequence_size=len(images),
num_retry_uploads=num_retries,
is_prediction=is_prediction,
)

return image, upload_time, upload_retry_attempts
Expand Down Expand Up @@ -390,6 +389,7 @@ def _save_annotation(image_id, imagedesc):
image_id=image_id,
job_name=batch_name,
num_retry_uploads=num_retries,
is_prediction=is_prediction,
)

return annotation, upload_time
Expand Down
17 changes: 12 additions & 5 deletions tests/test_project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,8 +381,8 @@ def test_project_upload_dataset(self):
],
"params": {"is_prediction": True},
"assertions": {
"upload": {"count": 2, "kwargs": {"is_prediction": True}},
"save_annotation": {"count": 2},
"upload": {"count": 2},
"save_annotation": {"count": 2, "kwargs": {"is_prediction": True}},
},
},
{
Expand All @@ -392,8 +392,8 @@ def test_project_upload_dataset(self):
],
"params": {"is_prediction": False},
"assertions": {
"upload": {"count": 1, "kwargs": {"is_prediction": False}},
"save_annotation": {"count": 1},
"upload": {"count": 1},
"save_annotation": {"count": 1, "kwargs": {"is_prediction": False}},
},
},
{
Expand All @@ -410,11 +410,18 @@ def test_project_upload_dataset(self):
"upload": {
"count": 1,
"kwargs": {
"is_prediction": True,
"batch_name": "prediction-batch",
"num_retry_uploads": 2,
},
},
"save_annotation": {
"count": 1,
"kwargs": {
"is_prediction": True,
"job_name": "prediction-batch",
"num_retry_uploads": 2,
},
},
},
},
]
Expand Down
Loading