Update setup.sh

[justinberi]

./setup.sh fails if apt update has not been issued previously (ie from a fresh docker container).

[jcnorby]

This is a good update, and certainly something that needs to be done prior to installing the repo. We will likely add it to the installation instructions since it is important that the update succeeds without failing, and simply adding it to this script may result in new users not catching that something failed.

[jcnorby]

Oops, looks like our CI setup doesn't like PRs opened by external users - we'll look into that.

[justinberi]

No worries would you like me to close the PR and open two issues for now?

• Documentation update
• External PRs cause CI to fail

[jcnorby]

I already opened an issue for those changes - let's leave this PR open for now since ideally making those changes would enable this to go through. If we change the workflow we can close it later. Thanks!

[justinberi]

Hey, I added some other minor refactors to the PR. Happy to revert if you wish to have only one commit in here.
Refactors include:

• speed improvement
• setup.sh exits on error (it was not doing this previously which caught me out)