Open
Conversation
added 7 commits
April 1, 2026 22:33
Collaborator
|
I would add some manual how too read logfile (including example). That is actually the most common question to me from colleagues. |
tajgr
reviewed
Apr 7, 2026
doc/deep_dive.md
Outdated
|
|
||
| - `driver`: The Python class name or alias (e.g., `osgar.drivers.gps:GPS`). | ||
| - `init`: A dictionary of parameters passed to the module's `__init__` method. | ||
| - `bus`: (Implicitly handled) Mapping of inputs and outputs. |
Collaborator
There was a problem hiding this comment.
There is not mapping of inputs and outputs.
tajgr
reviewed
Apr 7, 2026
| }, | ||
| "links": [ | ||
| ["serial.raw", "gps.raw"], | ||
| ["gps.position", "app.position"] |
Collaborator
There was a problem hiding this comment.
The app module is missing, thus the config is invalid.
tajgr
reviewed
Apr 7, 2026
doc/deep_dive.md
Outdated
| ### Simulation and Replay Mode | ||
| The "no system time" rule is what makes OSGAR powerful for both simulation and debugging: | ||
| - **In Replay**: `LogReader` reads the original timestamps from the log file. When a module calls `listen()`, it receives the exact same `timedelta` that was recorded during the real run. The module "thinks" it is running in real-time, even if the replay is running much faster. | ||
| - **In Simulation**: A simulator driver (e.g., `subt/simulation.py`) can publish a dedicated `sim_time_sec` channel. Other modules then synchronize their internal state to this published simulation time rather than the wall clock. This allows the simulation to run at any speed (or even pause) without affecting the robot's control logic. |
Collaborator
There was a problem hiding this comment.
From my point of view, the subt module is obsolete and it should not be listed in this doc.
tajgr
reviewed
Apr 7, 2026
doc/deep_dive.md
Outdated
| ```json | ||
| "links": [ | ||
| ["gps.position", "app.position"], | ||
| ["app.desired_speed", "base.speed"] |
Collaborator
There was a problem hiding this comment.
It should be explained why out_put/input channels may differs each other.
added 6 commits
April 10, 2026 21:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Elena prepared, I think a nice, documentation, how OSGAR works inside. If there is something you are missing there (or is even wrong!) please let me know. Thanks m.