demo: replace PermalinkNotFoundWarning with master-detail side panel#3
Merged
demo: replace PermalinkNotFoundWarning with master-detail side panel#3
Conversation
- Add ItemDetail side panel component that shows item details when a row is selected; replaces the floating PermalinkNotFoundWarning banner - Change App layout from column to row to accommodate the side panel - Various CSS tweaks for responsiveness (ellipsis on heading, fixed width on value column, cursor: pointer on rows) - Remove debug logging and dead effectiveDirection() from queries.ts - Add unreachable() assert helper to asserts.ts - Refactor rowAt switch to use unreachable() for exhaustive kind check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is selected; replaces the floating PermalinkNotFoundWarning banner
width on value column, cursor: pointer on rows)