-
Notifications
You must be signed in to change notification settings - Fork 25
use opencv's git instead of archive #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I really don't have a strong opinion on archive vs. git ... What's the advantage from your p.o.v ? In any case, if we decide to merge this, we would have to make sure that the upgrade is smooth (I think that right now autoproj would yell) |
|
I agree autoproj would probably yell. This is also the reason why right now an overwrite to use the latest version (master) is not smooth and I am in favor to use the git repro in the long run. Beside that, if someone is maintaining a repro with proper tags/branches I would always go for the repro because this gives you the ability to contribute. Any idea how to make the transition smooth? What is autoproj doing if you change the tar file? Couldn't we use the same method? |
Would need to implement proper detection in autoproj and tell the user we'll have to delete the folder, yes. Unless you think it is really urgent, I would mark this PR as "do not merge", merge the patch that changes the tarball URL, and add an issue on autoproj to add support for changing importers. |
|
no it is not urgent |
|
The opencv zip changed again, I updated the buildconf (#19), but as I think I saw the notification sylvain wanted to implement, we can reconsider this PR |
|
There are 3 PR open for opencv, which one (if any) is still valid? |
|
This one, at least i think so, #19 is a short term fix, until the "do not merge" tag is resolved |
No description provided.