Skip to content

Conversation

@D-Alex
Copy link
Member

@D-Alex D-Alex commented Oct 30, 2014

No description provided.

@doudou
Copy link
Member

doudou commented Oct 30, 2014

I really don't have a strong opinion on archive vs. git ... What's the advantage from your p.o.v ? In any case, if we decide to merge this, we would have to make sure that the upgrade is smooth (I think that right now autoproj would yell)

@D-Alex
Copy link
Member Author

D-Alex commented Oct 30, 2014

I agree autoproj would probably yell. This is also the reason why right now an overwrite to use the latest version (master) is not smooth and I am in favor to use the git repro in the long run. Beside that, if someone is maintaining a repro with proper tags/branches I would always go for the repro because this gives you the ability to contribute.

Any idea how to make the transition smooth? What is autoproj doing if you change the tar file? Couldn't we use the same method?

@doudou
Copy link
Member

doudou commented Oct 31, 2014

Any idea how to make the transition smooth? What is autoproj doing if you change the tar file? Couldn't we use the same method?

Would need to implement proper detection in autoproj and tell the user we'll have to delete the folder, yes.

Unless you think it is really urgent, I would mark this PR as "do not merge", merge the patch that changes the tarball URL, and add an issue on autoproj to add support for changing importers.

@D-Alex
Copy link
Member Author

D-Alex commented Oct 31, 2014

no it is not urgent

@planthaber
Copy link
Member

The opencv zip changed again, I updated the buildconf (#19), but as I think I saw the notification sylvain wanted to implement, we can reconsider this PR

@marvin2k
Copy link
Contributor

#21 will use system-packages. Hm, now that I see @D-Alex -- the compiled-from-source sections are still needed for MacOS? hrmpf

edit: no it is not... -> macos-brew

@jakobs
Copy link
Member

jakobs commented Jan 15, 2015

There are 3 PR open for opencv, which one (if any) is still valid?

@planthaber
Copy link
Member

This one, at least i think so,

#19 is a short term fix, until the "do not merge" tag is resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants