Feature/qt4 qt5 cleanup2 #276
Conversation
Was: fixes from workshop
They fail to build on ubuntu 22.04 Was: fixes from workshop
|
Not sure if anyone else should take a look at these, they seem fairly trivial to me. |
| cmake_package 'control/urdfdom' do |pkg| | ||
| pkg.define "BUILD_TESTING", "OFF" | ||
| end |
There was a problem hiding this comment.
N.B.: Ubuntu does provide liburdfdom-dev (and liburdfdom-headers-dev), which could make this actually obsolete.
However, on Ubuntu 20.04 it seems to be only version 1.0.4, Ubuntu 22.04 has version 3.0.1, Ubuntu 24.04 has 4.0.0 (not sure what version is required).
There was a problem hiding this comment.
It is still not obsolete, as someone could add an osdep override....
| '16.04,16.10,17.04,17.10': libsdformat4-dev | ||
| default: libsdformat6-dev | ||
| '18.04,20.04': libsdformat6-dev | ||
| default: libsdformat-dev |
There was a problem hiding this comment.
default will unfortunately only work for 22.04. In 24.04 it was removed from the ubuntu packages and requires an extra osrepo (e.g., http://packages.osrfoundation.org/gazebo/ubuntu-stable)
There was a problem hiding this comment.
There is a source definition:
https://github.com/rock-core/rock-package_set/blob/master/source.yml#L88-L92
That might be switched to github repo though...
https://github.com/gazebosim/sdformat
I currently don't know a way to tell autoproj to use source in the osdep file, only in the overrides.rb.
These are the remaining bits that found their way onto my feature/qt4-qt5 branch. Tested them with a qt4 only workspace, they seem to be fine.