Skip to content

Conversation

@fmrico
Copy link
Collaborator

@fmrico fmrico commented Jul 25, 2023

Hi @rodperex

This PR is not intended to be ready for merge, only for discussion. We could work on this PR to get a consensus ;)

Main changes:

  • All the configuration is read from node parameters instead of using the yaml library. This makes it more standard and avoids direct dependencies with the yaml library.
  • The XML tree (not the filename) is inserted in the blackboard under the behavior_tree_xml key. Using the input port is unnecessary, but I left it as it was. Consider reading it directly inside the BT node.
  • in bb_source_main.cpp I used directly bb_manager as a rclcpp::Node instead of using an auxiliary one. Does it fits for you?

I hope you like the changes. They are only improvement suggestions that I think will help us in the next steps.

Signed-off-by: Francisco Martín Rico <fmrico@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants