Change js/appConfig.example so you don't have to remove let#81
Open
owenleonard wants to merge 1 commit intoroest01:developfrom
Open
Change js/appConfig.example so you don't have to remove let#81owenleonard wants to merge 1 commit intoroest01:developfrom
let#81owenleonard wants to merge 1 commit intoroest01:developfrom
Conversation
JS variables defined using `let` cannot be redefined, but variables defined using var can. These changes allow the user to simply copy the file to their data directory and then change the settings they want to change. The settings in the data directory will override the default ones in appConfig.example.js. I also moved the order the config files are loaded by index.html so the data file is given preference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JS variables defined using
letcannot be redefined, but variablesdefined using var can. These changes allow the user to simply copy
the file to their data directory and then change the settings they
want to change. The settings in the data directory will override the
default ones in appConfig.example.js.
I also moved the order the config files are loaded by index.html so
the data file is given preference.