Skip to content

Update evaluation.js#82

Open
cosyd wants to merge 1 commit intoroest01:masterfrom
cosyd:patch-1
Open

Update evaluation.js#82
cosyd wants to merge 1 commit intoroest01:masterfrom
cosyd:patch-1

Conversation

@cosyd
Copy link

@cosyd cosyd commented May 14, 2021

Changed line 93 row.data[0] to row.data as per #75
Credit to https://github.com/Developer22974

Changed line 93 row.data[0] to row.data as per roest01#75
@owenleonard
Copy link
Contributor

Interesting. If you revert 1d6455a, do you still need this change?

I tried changing to row.data without success, but reverting the package updates fixed it. I think the package updates were incomplete - missing the corresponding yarn.lock changes - so they don't really pull down the right packages.

I'm interested to know if you get the same results or not...

@Victoare
Copy link

Yupp, this [0] removal is needed to run it properly.
@owenleonard : If you just change the file, but not tell the browser to forcefully download the js again (like ctrl+f5), it will use the cached version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants