feat: add protect-mcp to recommended MCP servers#41
feat: add protect-mcp to recommended MCP servers#41tomjwxf wants to merge 2 commits intorohitg00:mainfrom
Conversation
Adds protect-mcp (Ed25519 receipt signing + Cedar policy enforcement) to the add_when_needed section and as a commented-out server entry. Complements Pro Workflow's hook system — Pro Workflow handles workflow optimization (learnings, corrections, drift), while protect-mcp handles cryptographic audit trails and policy enforcement for tool calls. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds a new, disabled-by-default Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@mcp-config.example.json`:
- Line 24: Update the unpinned "protect-mcp" invocation in the args array to a
fixed, explicit version to ensure reproducible, auditable runs; replace the
token "protect-mcp" in the args entry with a pinned identifier such as
"protect-mcp@0.4.2" (the current stable) so the CLI invocation always uses that
exact release and update any documentation or comments referencing the args
array if needed.
- Around line 22-27: The "_protect-mcp" entry is currently inside mcpServers and
will be treated as active despite the underscore; move this object out of
mcpServers into a new top-level metadata section named "_optional_mcp_servers"
(matching the existing metadata pattern like "_recommendations" and "_scopes"),
and update its explanatory string to "Copy into mcpServers to enable" (and
adjust the `_comment` to explain it is disabled by default and must be copied to
mcpServers to enable); ensure the key name and command/args remain unchanged so
the snippet can be pasted unchanged when opt-in is desired.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
- Moved protect-mcp from mcpServers (where underscore prefix doesn't prevent loading) to a new _optional_servers section that is truly inert. Users copy into mcpServers to enable. - Pinned version to 0.5.2 for auditability and reproducibility, as CodeRabbit correctly noted for a compliance-focused tool. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Addressed both CodeRabbit findings:
|
What
Adds protect-mcp to the MCP config example:
add_when_neededrecommendation — respects the "start with 3" philosophy_) — users can uncomment when neededWhy
Pro Workflow already has best-in-class hook coverage (24 events), but the hooks produce unsigned logs. protect-mcp complements this by adding:
The two tools are complementary, not competing:
How to test
Context
🤖 Generated with Claude Code
Summary by CodeRabbit