Skip to content

Conversation

@roberlander2
Copy link
Contributor

Description

This PR updates the Auth2 service and model to match the changes made to the Core BB here: rokwire/core-building-block#675

Fixes #379

Review Time Estimate

Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.

  • Immediately
  • Within a week
  • When possible

Type of changes

Please select a relevant option:

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Other (any another change that does not fall in one of the above categories.)

Checklist:

Please select all applicable options:

  • I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
  • I have updated the CHANGELOG.
  • I have read the Contributor Guidelines.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My change requires updating the documentation.
  • I have made necessary changes to the documentation.
  • I have added tests related to my changes.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

roberlander2 and others added 30 commits July 12, 2023 12:35
…ing-passkeys-and-linking

# Conflicts:
#	example/pubspec.lock
@roberlander2 roberlander2 requested a review from shurwit October 3, 2023 21:21
@roberlander2 roberlander2 self-assigned this Oct 3, 2023
@shurwit shurwit changed the base branch from 330-more-identifiers-using-passkeys-and-linking to template-cleanup-passkeys October 6, 2023 21:39
Copy link
Collaborator

@shurwit shurwit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @roberlander2, LGTM!

@shurwit shurwit merged commit 502701a into template-cleanup-passkeys Oct 7, 2023
@shurwit shurwit deleted the 379-integrate-auth-refactor branch October 7, 2023 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants