Skip to content

Conversation

@roberlander2
Copy link
Contributor

@roberlander2 roberlander2 commented Jul 22, 2022

Description

This PR fixes the system update permission API handler to correctly update roles, groups, accounts, and service accounts that have been granted the permission being updated.
Depends on #547 and #551

Resolves #542

Review Time Estimate

Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.

  • Immediately
  • Within a week
  • When possible

Type of changes

Please select a relevant option:

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Other (any another change that does not fall in one of the above categories.)

Checklist:

Please select all applicable options:

  • I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
  • I have updated the CHANGELOG.
  • I have read the Contributor Guidelines.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My change requires updating the documentation.
  • I have made necessary changes to the documentation.
  • I have added tests related to my changes.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@roberlander2 roberlander2 self-assigned this Jul 22, 2022
@roberlander2 roberlander2 linked an issue Jul 22, 2022 that may be closed by this pull request
Copy link
Collaborator

@shurwit shurwit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @roberlander2, looking close! Just one comment below

@roberlander2 roberlander2 requested a review from shurwit August 2, 2022 19:17
@shurwit shurwit changed the base branch from develop to 516-update-role-permissions August 15, 2022 20:38
Copy link
Collaborator

@shurwit shurwit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @roberlander2, looks good! Just one comment below

@roberlander2 roberlander2 requested a review from shurwit August 17, 2022 22:13
petyos
petyos previously approved these changes Sep 20, 2022
Copy link
Collaborator

@petyos petyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Thanks.

Base automatically changed from 516-update-role-permissions to develop February 1, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Update permission should change roles/groups/accounts

4 participants