-
Notifications
You must be signed in to change notification settings - Fork 2
[ID-789]Admin API for filtering signed-in accounts #802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
[ID-789]Admin API for filtering signed-in accounts #802
Conversation
…n-accounts * main: update version to 1.57.0 [ID-790] Twilio phone login does not perform verification - logs & fix (#796) Just add logs to investigate twilio phone issue # Conflicts: # CHANGELOG.md
…n-accounts * main: Prepare v1.57.2 [ID-790] Twilio phone login does not perform verification - fix (#799) fot fix Fix lint issue.. update version to 1.57.1 More logs..arh # Conflicts: # CHANGELOG.md
…n-accounts * main: Prepare v1.57.3 [ID-800] Improve logs (#801)
|
Hi @petyos, i have test it and i think it is ok, but could you please take a deeper look at this because the pipeline is complicated and i want to be sure. i am working with outer join for first time and i want everything to be ok. Thank you! |
petyos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we already have an API that provides the sessions(https://api-dev.rokwire.illinois.edu/core/doc/ui/index.html#/Admin/get_admin_application_login_sessions), and we just need to extend it with the required parameters. We can add a new field called “account” to the current login session type. This account will be populated only for non-anonymous users and will be null for anonymous ones.
petyos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are not filtering by user-role; instead, after fetching the login sessions, you try to map the accounts to those sessions.
But imagine the following scenario: I send a user-role with the value abc, your query does not filter by abc, and it returns 20 records to the client. The client expects 0, since they provided a user-role.
We discussed that you should use a join between login sessions and accounts.
petyos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take into account the feedback.
petyos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take the feedback I leave carefully and make sure to polish your work.
petyos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take into account the feedback
|
@petyos Hi, this is mi first time with the indexes so if you could please tell me if its ok and maybe give me some advice of how to handle it. The api as working as its suposed to. Thank |
Description
Please, provide an admin API for filtering accounts which are signed in in a specific date-time range.
The filter should contain at least 3 optional fields:
user_role (the same like in the get accounts API: https://api-dev.rokwire.illinois.edu/core/doc/ui/index.html#/Admin/get_admin_application_accounts)
start date time
end date time
anonymous
user_role
The result should include the user account as well as its NetID, UIN, email, First and Last names
Additional context
Source: https://github.com/rokwire/illinois_admin/issues/742#issuecomment-3137176802
**Resolves #789
Review Time Estimate
Type of changes
Checklist: