Skip to content

Conversation

@jsafoan
Copy link
Contributor

@jsafoan jsafoan commented Jul 23, 2021

Resolves #55

@jsafoan jsafoan requested review from petyos and shurwit July 23, 2021 20:54
@jsafoan jsafoan self-assigned this Jul 23, 2021
@shurwit shurwit removed the request for review from petyos July 23, 2021 21:10
Copy link
Collaborator

@shurwit shurwit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jsafoan, this is looking close! I have left a few comments below.

@jsafoan jsafoan requested a review from shurwit September 15, 2021 15:32
@petyos
Copy link
Collaborator

petyos commented Nov 12, 2021

Hi @shurwit @jsafoan ,

Is this(#55) actual yet? I think the phone authentication type was handled using twilio etc. I am asking because I am wondering if we should close this PR or move this forward?

Thanks

@shurwit
Copy link
Collaborator

shurwit commented Nov 12, 2021

Hi @petyos, we were just talking about this. You are correct that this PR is not currently needed to support the authentication mechanisms that we are using for the ROKWIRE ecosystem. Because of this, this PR is lower priority. Since we have already done most of the work necessary, I believe we should come back to this and finish it up in case anyone wants to use it in the future. We will let you know when it is ready for your review. Thanks for checking in!

@petyos
Copy link
Collaborator

petyos commented Sep 20, 2022

Hi @shurwit , is this still valid from today point of view or we need to close it? Thanks

Hi @petyos, we recently discussed supporting this functionality again, but this PR is quite out of date and will need to be restructured and abstracted appropriately. We will work on this when we get a chance and re-request your review when we are ready. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Auth] Add Firebase support

4 participants