Skip to content

Restore PHP 7.4 support #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sstok wants to merge 1 commit into from
Closed

Restore PHP 7.4 support #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
strategy:
matrix:
php-version:
- '8.4'
- '7.4'

steps:
-
Expand Down Expand Up @@ -60,7 +60,7 @@ jobs:
strategy:
matrix:
php-version:
- '8.4'
- '7.4'

steps:
-
Expand Down Expand Up @@ -103,14 +103,19 @@ jobs:
strategy:
matrix:
include:
-
php-version: '7.4'
composer-options: '--prefer-stable'
symfony-version: '^7.4'
-
php-version: '8.4'
composer-options: '--prefer-stable'
symfony-version: '^8.0'

-
php-version: '8.4'
php-version: '8.5'
composer-options: '--prefer-stable'
symfony-version: '^7.4'
symfony-version: '^8.0'

steps:
-
Expand Down
2 changes: 1 addition & 1 deletion UPGRADE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ UPGRADE
From 3.x to 4.0
---------------

* Support for Symfony 6 was removed, PHP 8.4 and Symfony 7.4 is now the minimum required version.
* Support for Symfony 6 was removed, PHP 7.4 and Symfony 7.4 is now the minimum required version.

* The constructor of password constraints has changed, see (Upgrade instructions of the validator library)[https://github.com/rollerworks/PasswordStrengthValidator/blob/main/UPGRADE.md]

Expand Down
6 changes: 3 additions & 3 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,13 @@
}
],
"require": {
"php": ">=8.4",
"php": ">=7.4",
"rollerworks/password-strength-validator": "^3.0",
"symfony/framework-bundle": "^7.4 || ^8.0"
},
"require-dev": {
"matthiasnoback/symfony-dependency-injection-test": "^6.2",
"phpunit/phpunit": "^12.4",
"matthiasnoback/symfony-dependency-injection-test": "^5.1 || ^6.2",
"phpunit/phpunit": "^11.5 || ^12.4",
"rollerscapes/standards": "^1.0",
"symfony/phpunit-bridge": "^7.4 || ^8.0"
},
Expand Down
Loading