Stabilize runtime monitor and shell behavior#141
Closed
Vudgekek wants to merge 1 commit intoronitsingh10:mainfrom
Closed
Stabilize runtime monitor and shell behavior#141Vudgekek wants to merge 1 commit intoronitsingh10:mainfrom
Vudgekek wants to merge 1 commit intoronitsingh10:mainfrom
Conversation
|
Please shut the fuck up. Stop emailing me during the weekend. Thanks !
K
…On Sun, Mar 8, 2026 at 6:25 PM Ronit Singh ***@***.***> wrote:
*ronitsingh10* left a comment (ronitsingh10/FineTune#141)
<#141 (comment)>
Code review
No issues found. Checked for bugs and CLAUDE.md compliance.
🤖 Generated with Claude Code <https://claude.ai/code>
—
Reply to this email directly, view it on GitHub
<#141 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/B3B5VNV5MEMDFKKYTE6LIVD4PX6PTAVCNFSM6AAAAACWLBFKUGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DAMRQGE2DSNBZGA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
ronitsingh10
added a commit
that referenced
this pull request
Mar 9, 2026
Based on work from #141 by @Vudgekek. - Remove nonisolated deinit from DDCController, AudioDeviceMonitor, AudioProcessMonitor, DeviceVolumeMonitor (singleton-lifetime, never deallocated — deinits were dead code) - Remove @ObservationIgnored nonisolated(unsafe) from monitor listener properties (only needed for the removed deinits) - Snapshot matched/matchedUIDs/volumes before crossing to main thread in DDCController.probe() to avoid mutable state capture - Fix setupDisplayChangeObserver to hop to @mainactor before accessing isolated properties - Add outputChannelCount() to AudioDeviceID+Streams Co-Authored-By: Vudgekek <contact@vudgekek.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardens device/process monitoring paths to reduce startup/runtime churn and improve reliability.