fix: exclude FaceTime/avconferenced from audio tapping to prevent volume ducking#157
Open
IftatBhuiyan wants to merge 2 commits intoronitsingh10:mainfrom
Open
fix: exclude FaceTime/avconferenced from audio tapping to prevent volume ducking#157IftatBhuiyan wants to merge 2 commits intoronitsingh10:mainfrom
IftatBhuiyan wants to merge 2 commits intoronitsingh10:mainfrom
Conversation
…h10#123) macOS dictation chime was suppressed and dictation sometimes failed to start because FineTune's AudioProcessMonitor was not filtering dictation-related system daemons. These processes were being tapped with muteBehavior=.mutedWhenTapped, intercepting their audio output. Add the following to systemDaemonPrefixes: - com.apple.SpeechRecognitionCore (speech-to-text daemon) - com.apple.speech (speech framework services) - com.apple.dictation (dictation UI/coordination) - com.apple.corespeech / com.apple.CoreSpeech (CoreSpeech daemon) - com.apple.VoiceControl / com.apple.voicecontrol Add the following to systemDaemonNames: - speechrecognitiond, dictationd, corespeech Fixes ronitsingh10#123
…ume ducking When FineTune creates a process tap on avconferenced (FaceTime's real-time audio daemon) with muteBehavior=.mutedWhenTapped, it breaks the hardware Acoustic Echo Cancellation (AEC) loop. The system detects the broken AEC and drastically ducks audio volume as a fail-safe against mic feedback. Add the following to systemDaemonPrefixes: - com.apple.FaceTime - com.apple.avconference Add the following to systemDaemonNames: - FaceTime - avconferenced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When FineTune is running, FaceTime call audio (incoming audio from the other person) is extremely quiet. This "ducking" effect makes calls unusable. Quitting FineTune restores normal levels.
Root Cause
AudioProcessMonitorwas detectingavconferenced(the real-time audio daemon for FaceTime) and creating a process tap withmuteBehavior = .mutedWhenTapped. This intercepts the audio stream and breaks macOS's hardware Acoustic Echo Cancellation (AEC) loop. The system detects the broken AEC loop and drastically ducks the volume as a fail-safe to prevent feedback.Fix
Added FaceTime and
avconferencedto the system daemon filter lists in AudioProcessMonitor.swift so they are ignored by the tapping engine:systemDaemonPrefixes:com.apple.FaceTime,com.apple.avconferencesystemDaemonNames:FaceTime,avconferencedNote: This is a workaround that preserves audio quality at the cost of FaceTime not appearing in the FineTune app list.
Testing
Fixes #156