Skip to content

Implement TScatter2D (5D plots) #20187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 31, 2025
Merged

Implement TScatter2D (5D plots) #20187

merged 7 commits into from
Oct 31, 2025
+805 −108

Conversation

@couet
Copy link
Member

@couet couet commented Oct 24, 2025 •
edited
Loading

Implement TScatter2D.

  • New class TScatter2D.
  • New example gr019_scatter2d.C superimposing two scatter plot. The color and size take care of color and size ranges of the previous plot.
  • Modify TScatter to take care of the color and size ranges of the previous plot. TScatter2D does the same.
  • TScatted2D works in linear and log scale.
  • Modify gr006_scatter.C to dra two superimposed plots.
  • Implement log scale for color and size
  • Allow to save null vectors in TObject::SavePrimitiveVector
  • Allow to set log scale in TPaletteAxis diffrently from Logz
  • Add option P

@couet couet self-assigned this Oct 24, 2025
@couet couet requested review from linev and removed request for lmoneta and pcanal October 24, 2025 12:15
ferdymercury
ferdymercury reviewed Oct 24, 2025
View reviewed changes
@ferdymercury
Copy link
Collaborator

Thanks for this!

Fixes #16376

Old attempt: #17185

@ferdymercury ferdymercury added this to the 6.38.00 milestone Oct 24, 2025
linev
linev requested changes Oct 24, 2025
View reviewed changes
Copy link
Member

@linev linev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add checks for fGraph != nullptr.
SavePrimitive can be adjusted later

@github-actions
Copy link

github-actions bot commented Oct 24, 2025 •
edited
Loading

Test Results

    22 files      22 suites   3d 22h 35m 10s ⏱️
 3 706 tests  3 705 ✅ 0 💤 1 ❌
79 584 runs  79 583 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit ba863ba.

♻️ This comment has been updated with latest results.

@couet couet merged commit 9e0d890 into root-project:master Oct 31, 2025
24 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@linev linev linev approved these changes

@bellenot bellenot Awaiting requested review from bellenot bellenot is a code owner

@dpiparo dpiparo Awaiting requested review from dpiparo dpiparo is a code owner

+1 more reviewer

@ferdymercury ferdymercury ferdymercury left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@couet couet

Labels

None yet

Projects

Fixed in 6.38.00
Status: No status

Milestone

6.38.00

Development

Successfully merging this pull request may close these issues.

3 participants

@couet @ferdymercury @linev