Skip to content

Conversation

@linev
Copy link
Member

@linev linev commented Oct 30, 2025

  1. While THStack use name as variable name, always specify class name.
  2. When store TArrow, GetOption and not GetDrawOption should be used

Both problems detected with new tests from #20216

linev added 2 commits October 30, 2025 10:11
GetOption has to be used in TArrow constructor
While stack name used for saved variable name, always provide class name. Like for histograms and many other objects
@github-actions
Copy link

github-actions bot commented Oct 30, 2025

Test Results

    22 files      22 suites   4d 0h 24m 35s ⏱️
 3 702 tests  3 702 ✅ 0 💤 0 ❌
79 511 runs  79 511 ✅ 0 💤 0 ❌

Results for commit 9bce7ea.

♻️ This comment has been updated with latest results.

@dpiparo dpiparo merged commit 6488c92 into root-project:master Oct 31, 2025
53 of 54 checks passed
@linev linev deleted the fix_savearrow branch October 31, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants