Skip to content

Fix build changed count always showing total packages#46

Merged
retlehs merged 2 commits intomainfrom
fix/build-changed-count
Mar 19, 2026
Merged

Fix build changed count always showing total packages#46
retlehs merged 2 commits intomainfrom
fix/build-changed-count

Conversation

@retlehs
Copy link
Member

@retlehs retlehs commented Mar 19, 2026

Summary

  • The "Changed" column on the admin builds page has been showing the
    total package count (61403) since the Composer v1 removal/rename
  • The old builder used content-addressed p/ filenames for change
    detection; when p/ was removed, the detection was lost
  • Restores PreviousBuildDir on BuildOpts and compares each p2/
    file against the previous build via byte comparison
  • Display-only fix — R2 sync already has its own change detection and
    is unaffected

Test plan

  • make test passes
  • Deploy and verify next build shows a realistic changed count

🤖 Generated with Claude Code

retlehs and others added 2 commits March 19, 2026 18:17
The p/-based content-addressed change detection was removed when Composer
v1 support was dropped, leaving changedPkgs incrementing unconditionally.
This caused the admin builds page to show all packages as changed every
build. Restore detection using byte comparison of p2/ files against the
previous build.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@retlehs retlehs merged commit fd8a746 into main Mar 19, 2026
7 checks passed
@retlehs retlehs deleted the fix/build-changed-count branch March 19, 2026 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant