Skip to content

Clean up tests #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahcorde merged 1 commit into from
Mar 17, 2026
+20 −20
Merged

Clean up tests #224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/base.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ static constexpr size_t STRESS_TEST_NUM_THREADS = 500;
class Base
{
public:
virtual ~Base() {}
virtual ~Base() = default;
virtual void saySomething() = 0;
};

Expand Down
8 changes: 4 additions & 4 deletions test/fviz_case_study/fviz_default_plugin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
class Bar : public FvizPluginBase
{
public:
virtual ~Bar() = default;
void speak()
~Bar() override = default;
void speak() override
{
foo("from plugin Bar");
}
Expand All @@ -30,8 +30,8 @@ class Bar : public FvizPluginBase
class Baz : public FvizPluginBase
{
public:
virtual ~Baz() = default;
void speak()
~Baz() override = default;
void speak() override
{
foo("from plugin Baz");
}
Expand Down
2 changes: 1 addition & 1 deletion test/fviz_case_study/fviz_plugin_base.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
class FvizPluginBase
{
public:
virtual ~FvizPluginBase() {}
virtual ~FvizPluginBase() = default;
virtual void speak() = 0;
};

Expand Down
8 changes: 4 additions & 4 deletions test/global_plugins.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
class Kangaroo : public Base
{
public:
void saySomething()
void saySomething() override
{
printf("[Angry growl]\n");
}
Expand All @@ -48,7 +48,7 @@ class Kangaroo : public Base
class Panda : public Base
{
public:
void saySomething()
void saySomething() override
{
printf("[Excited squeaks!!!]\n");
}
Expand All @@ -57,7 +57,7 @@ class Panda : public Base
class Hyena : public Base
{
public:
void saySomething()
void saySomething() override
{
printf("[Cackling laugh]\n");
}
Expand All @@ -66,7 +66,7 @@ class Hyena : public Base
class Alpaca : public Base
{
public:
void saySomething()
void saySomething() override
{
printf("hhhaaaaaaaaaa\n");
}
Expand Down
10 changes: 5 additions & 5 deletions test/plugins1.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
class Dog : public Base
{
public:
void saySomething()
void saySomething() override
{
printf("Bark\n");
}
Expand All @@ -45,7 +45,7 @@ class Dog : public Base
class Cat : public Base
{
public:
void saySomething()
void saySomething() override
{
printf("Meow\n");
}
Expand All @@ -54,7 +54,7 @@ class Cat : public Base
class Duck : public Base
{
public:
void saySomething()
void saySomething() override
{
printf("Quack\n");
}
Expand All @@ -63,7 +63,7 @@ class Duck : public Base
class Cow : public Base
{
public:
void saySomething()
void saySomething() override
{
printf("Moooo\n");
}
Expand All @@ -72,7 +72,7 @@ class Cow : public Base
class Sheep : public Base
{
public:
void saySomething()
void saySomething() override
{
printf("Baaah\n");
}
Expand Down
8 changes: 4 additions & 4 deletions test/plugins2.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
class Robot : public Base
{
public:
void saySomething()
void saySomething() override
{
printf("Beep boop\n");
}
Expand All @@ -45,7 +45,7 @@ class Robot : public Base
class Alien : public Base
{
public:
void saySomething()
void saySomething() override
{
printf("Znornoff!!!\n");
}
Expand All @@ -54,7 +54,7 @@ class Alien : public Base
class Monster : public Base
{
public:
void saySomething()
void saySomething() override
{
printf("BEAAAHHHH\n");
}
Expand All @@ -63,7 +63,7 @@ class Monster : public Base
class Zombie : public Base
{
public:
void saySomething()
void saySomething() override
{
printf("Brains!!!\n");
}
Expand Down
2 changes: 1 addition & 1 deletion test/unique_ptr_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ TEST(MultiClassLoaderUniquePtrTest, nonLazyLoad) {
}
TEST(MultiClassLoaderUniquePtrTest, noWarningOnLazyLoad) {
try {
ClassLoader::UniquePtr<Base> cat = nullptr, dog = nullptr, rob = nullptr;
ClassLoader::UniquePtr<Base> cat, dog, rob;
{
class_loader::MultiLibraryClassLoader loader(true);
loader.loadLibrary(LIBRARY_1);
Expand Down
Loading