Skip to content

Conversation

@mergify
Copy link

@mergify mergify bot commented Nov 5, 2025

Description

Part of robograph-project/planning#38
Depends on ros2/launch#914

Make FindPackage{X} substitutions a subclass of PathSubstitution to get the path join operator for free.

Lets you change:

PathSubstitution(FindPackageShare('my_pkg')) / 'launch' / 'my_launch.yaml'
# or
PathJoinSubstitution([FindPackageShare('my_pkg'), 'launch', 'my_launch.yaml'])

into

FindPackageShare('my_pkg') / 'launch' / 'my_launch.yaml'

Is this user-facing behavior change?

New user-facing capability, does not affect existing behavior

Did you use Generative AI?

no

Additional Information


This is an automatic backport of pull request #494 done by [Mergify](https://mergify.com).

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
(cherry picked from commit 5820047)
@emersonknapp emersonknapp changed the title Make FindPackage substitutions a Path to get operator / (backport #494) [backport humble] Make FindPackage substitutions a Path to get operator / (backport #494) Nov 6, 2025
@emersonknapp emersonknapp moved this to In review in ROSGraph Planning Nov 6, 2025
@emersonknapp emersonknapp self-assigned this Nov 6, 2025
@ahcorde
Copy link
Contributor

ahcorde commented Nov 6, 2025

Pulls: ros2/launch#917, #496
Gist: https://gist.githubusercontent.com/ahcorde/6b0c4e2fc0bd4cce3b9882fa4a213918/raw/4007dc59ebe6bf5c50364a32b099989ec3334a5e/ros2.repos
BUILD args: --packages-above-and-dependencies launch_ros test_launch_ros launch
TEST args: --packages-above launch_ros test_launch_ros launch
ROS Distro: humble
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17405

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 5336ebd into humble Nov 6, 2025
2 of 3 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in ROSGraph Planning Nov 6, 2025
@ahcorde ahcorde deleted the mergify/bp/humble/pr-494 branch November 6, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants