Skip to content

Conversation

@mini-1235
Copy link
Contributor

Description

Fixes #2333

Did you use Generative AI?

Yes, Github Copilot to rephrase sentences

Additional Information

cc @fujitatomoya

Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@alsora can you also take a look at this?

@fujitatomoya
Copy link
Collaborator

@Mergifyio rebase

Signed-off-by: Maurice <mauricepurnawan@gmail.com>
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
@mergify
Copy link
Contributor

mergify bot commented Nov 5, 2025

rebase

✅ Branch has been successfully rebased

@wjwwood
Copy link
Member

wjwwood commented Nov 13, 2025

Please hold this pr, I need to follow up on what's going on here. I don't understand how/why all the pointers are the same. If someone know why this is now the case, please let me know.

@alsora
Copy link
Contributor

alsora commented Nov 16, 2025

This seems correct to me.
The documentation in the demo README correclty reflects that https://github.com/ros2/demos/tree/rolling/intra_process_demo, but for some reason this tutorial page had different docs that were wrong.

The image viewers use shared ptr subscriptions, so the same pointer published by the watermarker goes to both https://github.com/ros2/demos/blob/rolling/intra_process_demo/include/image_pipeline/image_view_node.hpp#L44

I don't like that we have duplicated docs, but this is unrelated to this PR, which looks good to me.

@sloretz
Copy link
Contributor

sloretz commented Nov 20, 2025

@wjwwood I saw you took an updated image of the posters this week. Would you be willing to push a commit with that image to this PR? 🧇

@wjwwood
Copy link
Member

wjwwood commented Nov 20, 2025

Yes, but I do need to make a pull request to the demo repo too. I was cleaning that up first. I'll try to do that tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation Error - Efficient Intra Process Communication

5 participants