-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix IPC tutorial #5988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: rolling
Are you sure you want to change the base?
Fix IPC tutorial #5988
Conversation
fujitatomoya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
@alsora can you also take a look at this?
|
@Mergifyio rebase |
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
✅ Branch has been successfully rebased |
|
Please hold this pr, I need to follow up on what's going on here. I don't understand how/why all the pointers are the same. If someone know why this is now the case, please let me know. |
|
This seems correct to me. The image viewers use shared ptr subscriptions, so the same pointer published by the watermarker goes to both https://github.com/ros2/demos/blob/rolling/intra_process_demo/include/image_pipeline/image_view_node.hpp#L44 I don't like that we have duplicated docs, but this is unrelated to this PR, which looks good to me. |
|
@wjwwood I saw you took an updated image of the posters this week. Would you be willing to push a commit with that image to this PR? 🧇 |
|
Yes, but I do need to make a pull request to the demo repo too. I was cleaning that up first. I'll try to do that tomorrow. |
Description
Fixes #2333
Did you use Generative AI?
Yes, Github Copilot to rephrase sentences
Additional Information
cc @fujitatomoya