Fix add bbox to node update signal#278
Merged
TeunHuijben merged 6 commits intoroyerlab:mainfrom Mar 31, 2026
Merged
Conversation
* cache node/edge_attr_schema in SQL graph * update_node_attrs only reads necessary columns * signal consumers need different columns, so we need a bigger change if we want to move away from fetching all columns * only fetch the necessary signal keys in update_node_attrs()
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #278 +/- ##
=======================================
Coverage 87.37% 87.37%
=======================================
Files 56 56
Lines 4744 4744
Branches 836 836
=======================================
Hits 4145 4145
Misses 379 379
Partials 220 220 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TeunHuijben
added a commit
that referenced
this pull request
Mar 31, 2026
This reverts commit 30a716c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix bug originating from #276