[context] do not fail on rolling releases with no VERSION_ID #1734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcantrell
requested changes
Oct 30, 2025
Contributor
dcantrell
left a comment
dcantrell
left a comment
There was a problem hiding this comment.
Looks good, just have some suggestions/questions about error handling from g_shell_unquote() and other functions.
bluca
force-pushed
the
os_release_rolling
branch
from
67106b0 to
b660e13
Compare
Archlinux and Debian Unstable have no VERSION_ID as they are rolling releases, but dnf-context's setup requires one. Fake a very high version number in those cases.
bluca
force-pushed
the
os_release_rolling
branch
from
b660e13 to
16d6e67
Compare
dcantrell
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Archlinux and Debian Unstable have no VERSION_ID as they are rolling releases, but dnf-context's setup requires one. Fake a very high version number in those cases.