log: Clear log_modules after changing log spec #4025
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was expecting to be able to change the logging of a running rr process by running `rr::apply_log_spec` at runtime under gdb, but this did not quite work, because unlike `set_all_logging`, it does not clear the log_modules cache. I think it would be useful for this to work, so clear log_modules at the end of this function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was expecting to be able to change the logging of a running rr process by running
rr::apply_log_specat runtime under gdb, but this did not quite work, because unlikeset_all_logging, it does not clear the log_modules cache. I think it would be useful for this to work, so clear log_modules at the end of this function.