Open
Conversation
added 2 commits
May 7, 2016 08:48
Add offsetPan, offsetTilt properties which apply additional rotation to non-stereo mode. This allows manual navigation on a stationary device. Add eulerAngles method to return the head transform pitch, yaw, and roll angles.
Add offsetPan, offsetTilt properties which apply additional rotation to non-stereo mode. This allows manual navigation on a stationary device. Add eulerAngles method to return the head transform pitch, yaw, and roll angles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change does two things to expose the head orientation parameters from the CBDViewController. First, it adds the eulerAngles() method to export results from the headTransform.eulerAngles() method. This makes it more convenient to pass orientation tracking information to Objective-C clients.
Second, this change adds offsetPan and offsetTilt properties, which are used to offset the view direction when vrModeEnabled is off. This makes it much easier for clients to add manual pan and tilt adjustment for devices that are not in a cardboard viewer.