Skip to content

Replace telnetlib with telnetlib3 for compatibility with python 3.13 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Replace telnetlib with telnetlib3 for compatibility with python 3.13 #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions nut2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
along with this program. If not, see <http://www.gnu.org/licenses/>.
"""

import telnetlib
import telnetlib3
import logging


Expand Down Expand Up @@ -75,7 +75,7 @@ def __del__(self):
try:
self._srv_handler.write(b"LOGOUT\n")
self._srv_handler.close()
except (telnetlib.socket.error, AttributeError):
except (telnetlib3.socket.error, AttributeError):
# The socket is already disconnected.
pass

Expand All @@ -94,7 +94,7 @@ def _connect(self):
logging.debug("Connecting to host")

try:
self._srv_handler = telnetlib.Telnet(self._host, self._port,
self._srv_handler = telnetlib3.Telnet(self._host, self._port,
timeout=self._timeout)

if self._login is not None:
Expand All @@ -108,7 +108,7 @@ def _connect(self):
result = self._srv_handler.read_until(b"\n", self._timeout).decode('utf-8')
if not result == "OK\n":
raise PyNUTError(result.replace("\n", ""))
except telnetlib.socket.error:
except telnetlib3.socket.error:
raise PyNUTError("Socket error.")

def description(self, ups):
Expand Down