Skip to content
This repository was archived by the owner on Nov 7, 2023. It is now read-only.

Conversation

@jessgusclark
Copy link
Member

@jessgusclark jessgusclark commented Aug 16, 2021

Uses the work from @vmandal from the 2021 Gitcoin Hackathon. rsksmart/rsk-gitcoin-hackathon-2021#12

See #78

features

  • Allows a user to request a credential from inside the RIF Id Manager
  • Uses the new VC Issuer format where credentials are requested from a single source.

modifications from the original PR

  • Changed the UX to a single panel to request both email and phone credentials
  • Show the current step's input and buttons rather than all at once
  • Credentials are stored in the "Credential" panel when first issued.
  • Link to the Verifier before saving into the DataVault

todo list

Before this can be merged, the following needs to be completed:

todo wish list

A few that would be nice to have, but not required to deployment

@coveralls
Copy link

coveralls commented Aug 16, 2021

Pull Request Test Coverage Report for Build 1208951271

  • 2 of 43 (4.65%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.9%) to 42.569%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/app/DataVault/DataVaultContainer.ts 0 1 0.0%
src/app/DataVault/DataVaultComponent.tsx 0 5 0.0%
src/features/credentials.ts 0 5 0.0%
src/app/DataVault/panels/AddCredential.tsx 0 30 0.0%
Totals Coverage Status
Change from base Build 936325088: -1.9%
Covered Lines: 360
Relevant Lines: 884

💛 - Coveralls

Copy link
Contributor

@ilanolkies ilanolkies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants