Have fa() return a htmltools::tag() object#59
Open
cpsievert wants to merge 5 commits intorstudio:mainfrom
Open
Have fa() return a htmltools::tag() object#59cpsievert wants to merge 5 commits intorstudio:mainfrom
cpsievert wants to merge 5 commits intorstudio:mainfrom
Conversation
wch
reviewed
May 11, 2021
wch
reviewed
May 11, 2021
Collaborator
|
Have you tested the performance of the old vs new code? Note that the tests will also need to include rendering it to HTML text. |
wch
reviewed
May 11, 2021
Co-authored-by: Winston Chang <winston@stdout.org>
wch
reviewed
May 12, 2021
wch
reviewed
May 12, 2021
Collaborator
|
Quick benchmark: system.time({
for (i in 1:5000) {
as.character(fa("calendar"))
}
})Result before: After: |
Collaborator
|
Following up on this PR, I think we should merge this only if we have a compelling use case in mind for the tags object over string. It's not too farfetched to imagine a document with a few hundred icons, but in that case, this change would add a non-negligible amount of time; we'd want to make sure there's a benefit that makes the cost worthwhile. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #58