Open
Conversation
bschwedler
force-pushed
the
rstudio-library-unittest
branch
from
8fce3ff to
ebc81cc
Compare
bschwedler
force-pushed
the
rstudio-library-unittest
branch
3 times, most recently
from
d38daf8 to
7c435e1
Compare
Create test harness chart for unit testing rstudio-library templates. Library charts cannot be tested directly, so this application chart depends on rstudio-library and will exercise its templates.
bschwedler
force-pushed
the
rstudio-library-unittest
branch
from
7c435e1 to
b7f30c5
Compare
Contributor
Author
|
@jforest I believe this should be good to go now. |
jforest
reviewed
Mar 18, 2026
| # Run tests for charts in other-charts/ directory | ||
| for dir in other-charts/*/; do | ||
| [ -d "$dir" ] || continue | ||
| if [ -d "$dir/tests" ]; then |
Contributor
There was a problem hiding this comment.
should this also apply to the regular charts?
| echo "${{ secrets.PPM_LICENSE_FILE }}" > ppm.lic | ||
| kubectl create secret generic ppm-license --from-file=ppm.lic --namespace posit-test | ||
| rm ppm.lic | ||
| # Use env vars and stdin to avoid secrets in temp files and command line args |
Comment on lines
+1
to
+3
| # Base values that null out all test categories | ||
| # Each test suite should include this file and then override only what it needs | ||
| # This reduces boilerplate and makes adding new test categories easier |
|
|
||
| dependencies: | ||
| - name: rstudio-library | ||
| version: "0.1.36" |
Contributor
There was a problem hiding this comment.
I'm not sure we want to hard code this. Do we want it to check all update to rstudio-library?
Comment on lines
+9
to
+10
| - name: sol-eng | ||
| email: docker@rstudio.com |
Contributor
There was a problem hiding this comment.
Not sol-eng is it? and probably want an @posit.co email
|
|
||
| | Name | Email | Url | | ||
| | ---- | ------ | --- | | ||
| | sol-eng | <docker@rstudio.com> | <https://github.com/rstudio/helm> | |
Contributor
There was a problem hiding this comment.
Same as in Chart.yaml probably not sol-eng and probably want an @posit.co email
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Create test harness chart for unit testing rstudio-library templates.
Library charts cannot be tested directly, so this application chart
depends on rstudio-library and will exercise its templates.
rstudio-library-testharness chart inother-charts/