Skip to content

feat: dynamically set bundled otelcol host through the Connect gcfg#809

Open
mconflitti-pbc wants to merge 5 commits intomainfrom
otel/set-otelcol-host
Open

feat: dynamically set bundled otelcol host through the Connect gcfg#809
mconflitti-pbc wants to merge 5 commits intomainfrom
otel/set-otelcol-host

Conversation

@mconflitti-pbc
Copy link
Contributor

@mconflitti-pbc mconflitti-pbc commented Mar 17, 2026

NOTE: Include these changes in the Connect 2026.03.0 Helm chart release PR. Can target this PR to that branch prior to merging that one to main.

Summary

When config.OpenTelemetry.Enabled is set to true, automatically defaults CollectorAdvertiseHost to the Connect service's cluster-internal DNS name (<fullname>.<namespace>.svc.cluster.local). Users can override this via config.OpenTelemetry.CollectorAdvertiseHost. No [OpenTelemetry] section is rendered when disabled.

Manual checks

# No [OpenTelemetry] section when disabled (default)
$ helm template my-release ./charts/rstudio-connect --set sharedStorage.create=true --set launcher.enabled=false | grep -A 5 OpenTelemetry
(no output)

# CollectorHost defaults to service DNS when enabled
$ helm template my-release ./charts/rstudio-connect --set sharedStorage.create=true --set launcher.enabled=false --set config.OpenTelemetry.Enabled=true | grep -A 5 OpenTelemetry
    [OpenTelemetry]
    CollectorAdvertiseHost = my-release-rstudio-connect.rsc-dev.svc.cluster.local
    Enabled = true

    [Python]
    Enabled = true

# User override takes precedence
$ helm template my-release ./charts/rstudio-connect --set sharedStorage.create=true --set launcher.enabled=false --set config.OpenTelemetry.Enabled=true --set config.OpenTelemetry.CollectorAdvertiseHost=customer.example.com | grep -A 5 OpenTelemetry
    [OpenTelemetry]
    CollectorAdvertiseHost = customer.example.com
    Enabled = true

    [Python]
    Enabled = true

… dyanmically set the collectorhost for the bundled otelcol when otel is enabled
@mconflitti-pbc mconflitti-pbc requested a review from a team as a code owner March 17, 2026 18:03
@mconflitti-pbc mconflitti-pbc changed the title feat: dynamically bundled otelcol host through the Connect gcfg feat: dynamically set bundled otelcol host through the Connect gcfg Mar 17, 2026
@dbkegley
Copy link
Contributor

The template changes look right to me. We'll also need to bump the chart version and add news. Make sure to run just docs after modifying the chart.yaml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants