Fix indentation for chronicleAgent environment variables#811
Merged
Conversation
Contributor
Contributor
|
Drats! No @claude in this repository. I'll do it on my machine. |
tdstein
approved these changes
Mar 18, 2026
lucasrod16
reviewed
Mar 18, 2026
Contributor
lucasrod16
left a comment
lucasrod16
left a comment
There was a problem hiding this comment.
I think this bug could have been caught with a helm unit test. It would be nice to have one to prevent future regressions. Something similar to the tests in https://github.com/rstudio/helm/blob/main/charts/rstudio-connect/tests/deployment_annotations_test.yaml. When chronicleAgent.env is set, assert that the deployment YAML renders as expected without errors
Contributor
Author
|
@tdstein do you want to have your claude add a test for this before we merge? |
Contributor
Will do as a follow on if it's blocking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #810