fix: Use a "package" htmlDependency for local copy of leaflet-providers#43
Merged
fix: Use a "package" htmlDependency for local copy of leaflet-providers#43
Conversation
- Fix providers_default() to read JS from the new inst/leaflet-providers/ subdirectory instead of the old versioned top-level path, which would fail at runtime - Remove stale comment and unused js_filename_for_inst variable - Remove dead file cleanup code in update script that only searched top-level inst/ - Add unit tests for providers_default() and dependency helpers Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
schloerke
added a commit
that referenced
this pull request
Mar 18, 2026
Resolve conflicts from PR #43 (package htmlDependency): - Adopt inst/leaflet-providers/ directory structure - Update providers_default() to use new path with error check - Update get_providers() version check for new path - Update CLAUDE.md and skill to reflect new file layout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
providers_default()and underlying functions to return an HTML dependency that points to the packaged file directly, rather than a temporary copy.