Merged
Conversation
- Upgrade leaflet-providers.js from v2.0.0 to v3.0.0 - Add version parameter validation (>= 1.0.10) with clear error messages - Implement file existence check in providers_default() for better error handling - Add comprehensive test suite for get_providers() with version validation - Update package version to 2.0.0.9000 in DESCRIPTION - Update NEWS.md with upgrade details - Add demo script and test suite for providers functionality - Reorganize providers_data.R with improved structure for v3.0.0
- Remove scripts/update_data_and_pkg.R and scripts/demo_app.R - Add .claude/skills/update-leaflet-providers.md skill for the full update workflow - Add developer section to README.Rmd pointing to the skill - Update .Rbuildignore to exclude .git, .claude, and CLAUDE.md Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Resolve conflicts from PR #43 (package htmlDependency): - Adopt inst/leaflet-providers/ directory structure - Update providers_default() to use new path with error check - Update get_providers() version check for new path - Update CLAUDE.md and skill to reflect new file layout
- Update README.md to reflect package htmlDependency structure - Add scripts/, README.html to .Rbuildignore - Add README.html, .playwright-mcp/ to .gitignore - Add object_length_linter = NULL to .lintr - Update revdep/README.md with latest check results Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Fix providers_loaded() docs to accurately describe plain list return type
- Switch use_providers() examples from require() to requireNamespace()
- Wrap V8-dependent examples in \donttest{} for CRAN compatibility
- Use consistent version numbers across examples
- Add warn = FALSE to readLines() calls to suppress incomplete final line warnings
- Use paste(sep="/") instead of file.path() for URL construction
- Fix NEWS.md to say "leaflet-providers.js" instead of "leaflet.js"
- Cache JS source string in providers_default() to avoid redundant disk reads
- Add use_providers() round-trip and invalid input tests
- Delete stale scripts/check-package.R
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update leaflet-providers JavaScript library from v2.0.0 to v3.0.0 and modernize the developer workflow.
leaflet-providers.jsfrom v2.0.0 to v3.0.0get_providers()to reject versions < 1.0.10 with a clear error messageproviders_default()for improved error handlingget_providers()covering structure validation and multi-version compatibilityscripts/directory with a Claude Code skill (.claude/skills/update-leaflet-providers.md) that guides the full update workflow/update-leaflet-providers.Rbuildignoreto exclude.git,.claude, andCLAUDE.mdCLAUDE.mdfor Claude Code project guidanceVerification