Skip to content

Conversation

@nodivbyzero
Copy link
Contributor

To run the go test command, this package requires the following tools to be installed:

  • python
  • twine
  • cargo
  • gpg
  • pip
  • wheel

This PR introduces a Dockerfile that includes all the necessary tools.

Copy link

@jonyoder jonyoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the README with steps to build and use the docker image? If it's complicated, it might be worth adding a Makefile, but I'm ok either way.

Copy link

@jonyoder jonyoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the instructions. This looks good to me, but the tests are failing when I try to run them:

--- FAIL: TestParse (14.70s)
--- FAIL: TestParse/pytest_signed_tarball (0.51s)
parse_test.go:447:
Error Trace:    /python-distribution-parser/parse_test.go:447
Error:          Received unexpected error:
exit status 2
Test:           TestParse/pytest_signed_tarball
--- FAIL: TestParse/pytest_signed_wheel (0.51s)
parse_test.go:447:
Error Trace:    /python-distribution-parser/parse_test.go:447
Error:          Received unexpected error:
exit status 2
Test:           TestParse/pytest_signed_wheel
FAIL
FAIL    github.com/rstudio/python-distribution-parser   14.705s
FAIL

@nodivbyzero
Copy link
Contributor Author

@jonyoder
As you can see, the CI passed, and I was able to run the tests successfully on my mac.
Could you try deleting the testdata folder and re-testing?

@jonyoder
Copy link

Feel free to merge it. No use holding it up since CI is passing.

@nodivbyzero nodivbyzero merged commit dbc3ced into main Nov 26, 2024
2 checks passed
@nodivbyzero nodivbyzero deleted the dockerfile-with-tools branch November 26, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants