Update install-node.sh: NODE_FILENAME#352
Open
adelmofilho wants to merge 2 commits intorstudio:masterfrom
adelmofilho:master
Open
Update install-node.sh: NODE_FILENAME#352adelmofilho wants to merge 2 commits intorstudio:masterfrom adelmofilho:master
adelmofilho wants to merge 2 commits intorstudio:masterfrom
adelmofilho:master
Conversation
When I tried to install the node through this script on my raspberry, independent of the chosen NODE_SHA256 the downloaded node was the same because of the NODE_FILENAME definition, that was hold on linux-x64. With this change, it´s more explicit the need for select the right distribution - This change has revelance once the number of unsucess on installing shiny server on raspberry is high, in general because of this issue.
Update install-node.sh: NODE_FILENAME
|
Instead of opening a new PR, can I make a suggestion here: Lines 8-9 could be replaced by: Tested on Rasperry Pi 3 (Rasabian) and 64-bit Manjaro Linux. Although it looks like there is a merge conflict that needs to be resolved first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I tried to install the node through this script on my raspberry, independent of the chosen NODE_SHA256 the downloaded node was the same because of the NODE_FILENAME definition, that was hold on linux-x64. With this change, it´s more explicit the need for select the right distribution - This change has revelance once the number of unsucess on installing shiny server on raspberry is high, in general because of this issue.