Skip to content

fix: Skip button duration selection issue (QA issues fixes)#1720

Open
subodhr258 wants to merge 1 commit intodevelopfrom
fix/qa-issues
Open

fix: Skip button duration selection issue (QA issues fixes)#1720
subodhr258 wants to merge 1 commit intodevelopfrom
fix/qa-issues

Conversation

@subodhr258
Copy link
Copy Markdown
Collaborator

@subodhr258 subodhr258 commented Mar 11, 2026

Issue - https://github.com/rtCamp/godam-core/issues/877

This pull request updates the styling for the video editor page to improve the appearance and consistency of UI elements. The most important changes focus on border radius adjustments and background styling refinements.

Styling improvements for UI elements:

  • Removed the overflow: hidden property from the main video editor container, which may affect how content is clipped within the container.
  • Added border-radius: 0.75rem to the __header section for a more rounded appearance.
  • When the header is open (.is-open), added a specific border radius (border-radius: 0.75rem 0.75rem 0 0) to the top corners, enhancing the visual distinction between open and closed states.

Recording

Screen.Recording.2026-03-11.at.7.43.03.PM.mov

Copilot AI review requested due to automatic review settings March 11, 2026 14:15
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Video Editor collapsible section styling to resolve UI clipping/selection issues (notably around the skip-duration control) and improve visual consistency in the section header’s rounded corners.

Changes:

  • Removed overflow: hidden from the collapsible section container to prevent child UI (e.g., dropdowns/popovers) from being clipped.
  • Added rounded corners to the collapsible header, with a distinct radius treatment for the open state.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown

🔍 WordPress Plugin Check Report

⚠️ Status: Passed with warnings

📊 Report

🎯 Total Issues ❌ Errors ⚠️ Warnings
16 0 16

⚠️ Warnings (16)

📁 composer.json (1 warning)
📍 Line 🔖 Check 💬 Message
0 missing_composer_json_file The "/vendor" directory using composer exists, but "composer.json" file is missing.
📁 readme.txt (2 warnings)
📍 Line 🔖 Check 💬 Message
0 mismatched_plugin_name Plugin name "GoDAM - Organize WordPress Media Library & File Manager with Unlimited Folders for Images, Videos & more" is different from the name declared in plugin header "GoDAM".
0 trademarked_term The plugin name includes a restricted term. Your chosen plugin name - "GoDAM - Organize WordPress Media Library & File Manager with Unlimited Folders for Images, Videos & more" - contains the restricted term "wordpress" which cannot be used at all in your plugin name.
📁 assets/build/css/main.css (1 warning)
📍 Line 🔖 Check 💬 Message
0 EnqueuedStylesScope This style is being loaded in all contexts.
📁 assets/src/libs/analytics.min.js (6 warnings)
📍 Line 🔖 Check 💬 Message
0 EnqueuedScriptsScope This script is being loaded in all frontend contexts.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880 (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/2026/03/11/demo-post-post/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/demo-page-post/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/demo-attachment-post/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/?godam-video=demo-godam-video-post (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead.
📁 assets/build/js/main.min.js (6 warnings)
📍 Line 🔖 Check 💬 Message
0 EnqueuedScriptsScope This script is being loaded in all frontend contexts.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880 (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/2026/03/11/demo-post-post/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/demo-page-post/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/demo-attachment-post/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/?godam-video=demo-godam-video-post (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead.

🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check

@subodhr258 subodhr258 requested a review from KMchaudhary March 11, 2026 14:20
@subodhr258 subodhr258 changed the title fix: Skip button duration selection issue fix: Skip button duration selection issue (QA issues fixes) Mar 11, 2026
Copy link
Copy Markdown
Collaborator

@KMchaudhary KMchaudhary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@subodhr258, we can use CSS container query to show and hide the skip forward and backwards buttons, for horizontal and vertical videos. This way user will also get a live preview of the skip button in the video player for horizontal video.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants