Open
Conversation
- Add support for pnpm global filter arguments (`--filter`) across all pnpm commands (`list`, `outdated`, `install`, etc.). - Merge pnpm filters with native command arguments (`--filter` + custom args like `--depth`). - Implement proper handling for `Vec<String>` (text filters) and `Vec<OsString>` (OS-specific filters). - Add unit tests for `merge_pnpm_args` and CLI parsing to validate expected behavior. This enables users to apply workspace-specific filtering directly via `--filter @scope` before running pnpm commands, reducing token overhead by excluding irrelevant packages/dependencies from output. Fixes: rtk-ai#259 FIXME: Add notes for typechecking/building with workspaces when filters are applied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--filter) across all pnpm commands (list,outdated,install, etc.).--filter+ custom args like--depth).Vec<String>(text filters) andVec<OsString>(OS-specific filters).merge_pnpm_argsand CLI parsing to validate expected behavior.This enables users to apply workspace-specific filtering directly via
--filter @scopebefore running pnpm commands, reducing token overhead by excluding irrelevant packages/dependencies from output.Fixes: #259
FIXME: Add notes for typechecking/building with workspaces when filters are applied.
Note: Not sure but the PnpmCommands::Build -> next_cmd::run seems suspect to me. What if the project use anything else (vite / rspack / ...) ?